From dev-return-11714-apmail-lucenenet-dev-archive=lucenenet.apache.org@lucenenet.apache.org Tue Sep 22 07:34:43 2020 Return-Path: X-Original-To: apmail-lucenenet-dev-archive@www.apache.org Delivered-To: apmail-lucenenet-dev-archive@www.apache.org Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with ESMTP id 741551A175 for ; Tue, 22 Sep 2020 07:34:43 +0000 (UTC) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 2546E12367F for ; Tue, 22 Sep 2020 07:34:43 +0000 (UTC) Received: (qmail 52987 invoked by uid 500); 22 Sep 2020 07:34:42 -0000 Delivered-To: apmail-lucenenet-dev-archive@lucenenet.apache.org Received: (qmail 52957 invoked by uid 500); 22 Sep 2020 07:34:42 -0000 Mailing-List: contact dev-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucenenet.apache.org Delivered-To: mailing list dev@lucenenet.apache.org Received: (qmail 52945 invoked by uid 99); 22 Sep 2020 07:34:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2020 07:34:42 +0000 From: =?utf-8?q?GitBox?= To: dev@lucenenet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Blucenenet=5D_theolivenbaum_commented_on_pull_reque?= =?utf-8?q?st_=23344=3A_remove_unnecessary_dictionary_lookup_in_FieldCacheIm?= =?utf-8?q?pl?= Message-ID: <160076008228.32230.11778977517444816401.asfpy@gitbox.apache.org> Date: Tue, 22 Sep 2020 07:34:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: theolivenbaum commented on pull request #344: URL: https://github.com/apache/lucenenet/pull/344#issuecomment-696558106 Hi @NightOwl888 , good point regarding the comments, will keep it in mind for future commits! One thing that comes to mind, what's the official goal reg. version parity with the Java Lucene source-code? Besides keeping binary compatibility with 4.8, is the goal to evolve exactly as in the original source-code / binary protocol, or is LuceneNet planning to diverge from it? Just to understand what kind of code changes could be introduced here :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org