lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum opened a new pull request #345: Reduce casting
Date Wed, 23 Sep 2020 04:08:48 GMT

theolivenbaum opened a new pull request #345:
URL: https://github.com/apache/lucenenet/pull/345


   Hi @NightOwl888 - did a first pass on some applying some analyzer changes for a few quick
wins:
   - change ` (a != null && a is MyClass)` to `a is MyClass mc`
   - change `== null` to `is null`
   - change `!= null` to `is object`
   
   I did double check that there was no crazy operator overloading for == that would change
behavior - it seems like only the [State.cs](https://github.com/apache/lucenenet/blob/master/src/Lucene.Net/Util/Automaton/State.cs#L377)
class has overloaded it, and the behavior is the same with is null / is object. 
   
   Also changed a few fields to read-only, and one regex variable to static as suggested by
the analyzer too.
   
   Regarding your previous comment, do you think this kind of changes needs the "LUCENENET"
comments you mentioned?
   
   By the way, is there any docs or quick start on running the tests locally? And are the
tests run automatically on PR, or manually? Just to know if I should bother trying to set
it up locally, or easier to let them run and just check the results...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message