lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #354: TaskMergeScheduler: Salvage or deprecate?
Date Tue, 29 Sep 2020 08:27:33 GMT

NightOwl888 commented on issue #354:
URL: https://github.com/apache/lucenenet/issues/354#issuecomment-700536654


   > If there's already a faster and more stable implementation with ConcurrentMergeScheduler,
is there any reason to keep TaskMergeScheduler? Or are you saying that there isn't currently
a replacement for TaskMergeScheduler?
   
   - `ConcurrentMergeScheduler` is a direct port from Lucene. 
   - `TaskMergeScheduler` was only required because `ConcurrentMergeScheduler` didn't compile
on .NET Standard 1.x.
   
   The only reason to consider keeping `TaskMergeScheduler` is the amount of time that has
been invested in it already. That said, I don't plan to invest any more time on it myself,
so if we don't have a party willing to make it production ready it will definitely be   excluded
from the final release. IMO, there is no reason to hold up the release for a duplicate of
something we already have.
   
   But if someone were willing to step up and make `TaskMergeScheduler` reliable and more
performant than `ConcurrentMergeScheduler`, it would not only be worth keeping but we could
potentially have a new default setting.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message