lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #353: Refactor IndexSearcher
Date Fri, 25 Sep 2020 13:30:37 GMT

NightOwl888 commented on issue #353:
URL: https://github.com/apache/lucenenet/issues/353#issuecomment-698111055


   @jeme - Good point. The types involved are all internal, so this can technically be done
at any point. I have changed the milestone to Future.
   
   Also, after chewing on this a bit more, I don't think there is as much benefit as I thought.
The classes might not be eliminated due to the fact we need the state passed into each thread.
The best we can probably do is to change this from
   
   ```c#
   runner.Submit(new SearcherCallableNoSort(@lock, this, m_leafSlices[i], weight, after, nDocs,
hq));
   ```
   
   to
   
   ```c#
   runner.Submit(new SearcherCallableNoSort(@lock, this, m_leafSlices[i], weight, after, nDocs,
hq).Call);
   ```
   
   by changing the parameter of `Submit()` to a `Func<T>`. Although, there may be a
cleaner option with `ParameterizedThreadStart`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message