lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum commented on issue #350: Change ScoreDoc to struct?
Date Wed, 23 Sep 2020 14:52:11 GMT

theolivenbaum commented on issue #350:
URL: https://github.com/apache/lucenenet/issues/350#issuecomment-697484139


   Guess that's exactly the cost of doing so - but i've the impression there are already a
lot of places on the Lucene source code that rely on the similar pattern, instead of using
generics + interfaces to enforce this at compile time:
   
   ```csharp
   if(!(obj is Class)) throw new Exception("Expected type X");
   ```
   
   IMO, this could be one case where the switch is worth, as currently Lucene allocates one
ScoreDoc object for every search hit that needs to be scored, per search... But obviously
better to test first :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message