lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #350: Change ScoreDoc to struct?
Date Wed, 23 Sep 2020 14:19:13 GMT

NightOwl888 commented on issue #350:
URL: https://github.com/apache/lucenenet/issues/350#issuecomment-697429988


   Given the fact that Lucene relies on inheritance in this case to extend a data container
with additional fields, it feels like we are trying to force a struct into the design. Specifically,
we are breaking the is-a relationship in the inheritance model for all of the subclasses,
which would make it more difficult to use (assuming that it doesn't need to be cast often
by users, in that case we may actually be helping).
   
   The usage of this class is such that it acts as a data delivery mechanism, similar to the
tables in Entity Framework, which are classes.
   
   As such, IMO this probably isn't a good candidate for a struct.
   
   I am curious to hear other opinions on this case, though. Especially from users. This does
seem to have potential to make a big performance impact.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message