lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum commented on issue #346: Remove Debugging.AssertsEnabled
Date Wed, 23 Sep 2020 09:28:13 GMT

theolivenbaum commented on issue #346:
URL: https://github.com/apache/lucenenet/issues/346#issuecomment-697247191


   @eladmarg i think in this case specific we could attack the few places that were calling
this in a loop and just get rid of the overhead.
   
   @NightOwl888 from what I understand, in any case using IConfigurationFactory with custom
providers, that would be set once at the start of the program, and not changed afterwards
right? From a quick glance, it doesn't seem that Properties support live-reload of configuration
in any case. So if it's cached on the Lazy<bool> or within the more complex System.Properties
code, it is cached - which should make [this PR](https://github.com/apache/lucenenet/pull/347)
a non-breaking change...
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message