lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #346: Remove Debugging.AssertsEnabled
Date Wed, 23 Sep 2020 08:35:35 GMT

NightOwl888 commented on issue #346:
URL: https://github.com/apache/lucenenet/issues/346#issuecomment-697219417


   > I've wrapped Debugging.AssertsEnabled around a lazy - but I'm not sure if there is
any other way of setting it after lucene is loaded. I could only find this one in CheckIndex:
   
   CheckIndex is wrapped into a dotnet tool, `lucene-cli`. So, it is actually run as a separate
process.
   
   > I've the impression that only EnvironmentVariablesConfigurationProvider implements
IConfigurationProvider, and thus it would only be read once from the current environment variables.
   
   That is the default setting when running `Lucene.Net.dll` out of the box. The user has
the ability to inject their own configuration settings through `IConfigurationFactory`. The
test framework and `lucene-cli` are set up to inject their own configuration when run, which
read from JSON files (this isn't documented yet, see #307).
   
   This differs a bit from the state of things in .NET - in Java, the property values can
actually be read inside of the application. We did the next best thing, which was to use .NET
configuration providers to read the settings from outside of the application. There aren't
a lot of settings that are actually meaningful in Lucene.NET, but enabling asserts is one
of the biggest ones. Of course, by default the setting is missing in the provider and after
it loads and realizes it is missing, it uses the second parameter as the default setting.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message