lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum commented on issue #346: Remove Debugging.AssertsEnabled
Date Wed, 23 Sep 2020 08:07:50 GMT

theolivenbaum commented on issue #346:
URL: https://github.com/apache/lucenenet/issues/346#issuecomment-697205395


   Think I found a better solution for this case that keeps the current assert logic, but
removes it from tight loops: https://github.com/apache/lucenenet/pull/347
   
   I've wrapped Debugging.AssertsEnabled around a lazy - but I'm not sure if there is any
other way of setting it after lucene is loaded. I could only find this one in CheckIndex:
   
   ```csharp
   // LUCENENET specific - rather than having the user specify whether to enable asserts,
we always run with them enabled.
   Debugging.AssertsEnabled = true;
   ```
   I've the impression that only EnvironmentVariablesConfigurationProvider implements IConfigurationProvider,
and thus it would only be read once from the current environment variables.
   
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message