lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] theolivenbaum commented on pull request #345: Reduce casting
Date Tue, 22 Sep 2020 16:58:41 GMT

theolivenbaum commented on pull request #345:
URL: https://github.com/apache/lucenenet/pull/345#issuecomment-696850081


   @NightOwl888 yeah for sure different IL for the != case, but I did check if any operator
overloads would cause issues with the changes.
   
   My only minor issue with the `!(c is null)` option is that when the `is not null` finally
becomes available, it will be harder to do a replace all :) 
   But happy to change to the `!(c is null)` case for now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message