lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 opened a new pull request #327: Implementation of Replacement for Debug.Assert() that can be turned on/off in Release build (addresses #326)
Date Mon, 24 Aug 2020 18:29:34 GMT

NightOwl888 opened a new pull request #327:
URL: https://github.com/apache/lucenenet/pull/327


   This fixes #326 
   
   `Debugging.Assert()` overloads were created to replace `Debug.Assert()` so they don't get
compiled out of production builds. In addition, the `message` parameter is a `Func<string>`
so we don't have the performance impact (or errors) caused by building messages for succeeding
asserts.
   
   The task was expanded to include a workflow for turning off asserts when running tests.
This is primarily to verify that the release build will function with asserts disabled, but
can also be used to improve CI performance by reducing the amount of testing that happens.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message