lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)
Date Fri, 15 May 2020 08:00:09 GMT

NightOwl888 commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425631736



##########
File path: src/Lucene.Net.TestFramework/Lucene.Net.TestFramework.csproj
##########
@@ -63,14 +63,34 @@
     <PackageReference Include="System.Diagnostics.TraceSource" Version="$(SystemDiagnosticsTraceSourcePackageVersion)"
/>
     <PackageReference Include="System.Net.Primitives" Version="$(SystemNetPrimitivesPackageVersion)"
/>
     <PackageReference Include="System.Threading.Thread" Version="$(SystemThreadingThreadPackageVersion)"
/>
+    <PackageReference Include="Microsoft.Extensions.Configuration" Version="1.1.2" />

Review comment:
       Have a look at [this example in ICU4N](https://github.com/NightOwl888/ICU4N/blob/master/src/ICU4N/ICU4N.csproj#L43).
We just added `_NET4_5_1` to the end of the MSBuild property name. All package versions need
to be moved into `Dependencies.props` because it is a nightmare to update them otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message