lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)
Date Fri, 15 May 2020 07:50:56 GMT

NightOwl888 commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425624715



##########
File path: src/Lucene.Net.TestFramework/luceneTestSettings.json
##########
@@ -2,7 +2,8 @@
     "analysis.data.dir": "",
     "egothor.stemmer.charset": "UTF-8",
     "kuromoji.data.dir": "",
-    "lucene:version": "4.8.1",
+    "lucene.version": "4.8.1",

Review comment:
       From what I understand about the Java property names, the.`.` *is* a classification
that may be nested in the file.  It does look weird, but it is how it was done in Lucene.
To make them consistent in .NET, it would be best to use `:` in all properties (I mentioned
this in another comment). 
   
   If you have an idea that you think would be more intuitive to. NET users, then by all means,
let's discuss it.
   
   Do note that `user.timezone` is another special case. In Java this property is read/write,
but in .NET, TimeZoneInfo.Local is readonly. So this property is technically not a user level
machine setting like in Java, it is only used in a few places to set the timezone when creating
DateTime instances. Since this is only used to mock the time zone for testing, perhaps it
should be named `tests:timezone` in .NET.
   
   Note that to ensure we don't accidentally revert anything during future porting, all places
where we deliberately diverged from Java should have a C# comment beginning with `LUCENE.NET
specific - ` followed by an  explanation why we diverged. The only exception for this is code
that is in the `Support` folder, which is understood to be different from Java Lucene.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message