lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)
Date Fri, 15 May 2020 04:25:12 GMT

NightOwl888 commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425558751



##########
File path: src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs
##########
@@ -767,7 +773,29 @@ public virtual void BeforeClass()
         {
             try
             {
+
+#if NETSTANDARD
+                string currentPath = System.AppContext.BaseDirectory;
+#else
+                string currentPath = AppDomain.CurrentDomain.BaseDirectory;
+#endif
+
+                configurationBuilder = new ConfigurationBuilder();
+
+#if NETSTANDARD
+                string fileName = "luceneTestSettings.json";
+                configurationBuilder.AddJsonFilesFromRootDirectoryTo(currentPath, fileName);
+                configurationBuilder.AddEnvironmentVariables();

Review comment:
       This request has been superseded by my other comments in the `TestConfigurationFactory`
class example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message