lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)
Date Fri, 15 May 2020 03:52:43 GMT

NightOwl888 commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425551625



##########
File path: src/Lucene.Net.TestFramework/luceneTestSettings.json
##########
@@ -2,7 +2,8 @@
     "analysis.data.dir": "",
     "egothor.stemmer.charset": "UTF-8",
     "kuromoji.data.dir": "",
-    "lucene:version": "4.8.1",
+    "lucene.version": "4.8.1",

Review comment:
       There really has been no concerted effort to make the system properties consistent.
This one was simply removed because it was incompatible with our build process. It is good
to go through them all now to weed out the ones that have no benefit.
   
   The only danger with `lucene.version" is that we will probably end up using this file to
create documentation later, and we need to be sure we don't document any settings that weren't
carried over from Java.
   
   Also, there is a test that is looking for this setting that is not finding it, but the
result is a false positive. It would be better just to comment out the test - keep the code
there so we have parity with Java, but comment it so we don't have an extra test to run that
takes up time with no added benefit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message