lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] bongohrtech commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)
Date Fri, 15 May 2020 03:29:54 GMT

bongohrtech commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425546443



##########
File path: src/Lucene.Net.TestFramework/luceneTestSettings.json
##########
@@ -2,7 +2,8 @@
     "analysis.data.dir": "",
     "egothor.stemmer.charset": "UTF-8",
     "kuromoji.data.dir": "",
-    "lucene:version": "4.8.1",
+    "lucene.version": "4.8.1",

Review comment:
       I simply searched for references to SystemProperties.GetProperty and extracted these
into the configuration file. Is the danger here that it gets overriden by the file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message