lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [lucenenet] NightOwl888 commented on issue #248: Missing BufferedChecksum
Date Wed, 06 May 2020 02:10:59 GMT

NightOwl888 commented on issue #248:
URL: https://github.com/apache/lucenenet/issues/248#issuecomment-624406460


   The issue here is described in #255. The issue is that `IChecksum` was ported over from
Java when .NET already has an abstraction for this purpose, namely, `HashAlgorithm`.
   
   An [attempt was made](https://github.com/NightOwl888/lucenenet/tree/fix/hashalgorithm)
to make the conversion using [Crc32.NET](https://www.nuget.org/packages/Crc32.NET/), an implementation
of `HashAlgorithm` that implements CRC32. Some of the tests pass, but the CheckIndex functionality
is no longer functional with this draft implementation.
   
   Since this wasn't considered to be a primary interface and we didn't expect any users to
utilize it, it has been made internal until a `HashAlgorithm`-derived implementation of CRC32
can be properly implemented and tested. Issue #255 is up for grabs if you would like to proceed
with it to make a public implementation again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message