lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shad Storhaug (Jira)" <j...@apache.org>
Subject [jira] [Created] (LUCENENET-626) API: Review to ensure IDisposable is being used correctly and disposable pattern implemented correctly
Date Thu, 10 Oct 2019 18:18:00 GMT
Shad Storhaug created LUCENENET-626:
---------------------------------------

             Summary: API: Review to ensure IDisposable is being used correctly and disposable
pattern implemented correctly
                 Key: LUCENENET-626
                 URL: https://issues.apache.org/jira/browse/LUCENENET-626
             Project: Lucene.Net
          Issue Type: Task
          Components: Lucene.Net Core, Lucene.Net Demo, Lucene.Net.Analysis.Common, Lucene.Net.Analysis.ICU,
Lucene.Net.Analysis.Kuromoji, Lucene.Net.Analysis.Morfologik, Lucene.Net.Analysis.Phonetic,
Lucene.Net.Analysis.SmartCN, Lucene.Net.Analysis.Stempel, Lucene.Net.Benchmark, Lucene.Net.Classification,
Lucene.Net.Codecs, Lucene.Net.Expressions, Lucene.Net.Facet, Lucene.Net.Grouping, Lucene.Net.Highlighter,
Lucene.Net.ICU, Lucene.Net.Join, Lucene.Net.Memory, Lucene.Net.Misc, Lucene.Net.Queries, Lucene.Net.QueryParser,
Lucene.Net.Replicator, Lucene.Net.Sandbox, Lucene.Net.Spatial, Lucene.Net.Suggest, Lucene.Net.TestFramework
    Affects Versions: Lucene.Net 4.8.0
            Reporter: Shad Storhaug


There have been several issues found recently with the disposable pattern not being implemented
correctly. I have also been made aware that there is at least one class (Lucene.Net.Store.Lock,
if I recall correctly) that is designed to be re-opened after it is closed.

We need a review to ensure all classes that implement disposable are doing it correctly and
have correctly implemented the dispose pattern both for sealed and unsealed types. We also
need to have a close look at whether any classes should be reverted back to using Close()
instead of Dispose() on account that the class instance was designed to be used again after
the Dispose() call.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message