lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shad Storhaug (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LUCENENET-592) Lucene.Net.QueryParsers.Flexible.Core.Util.UnescapedCharSequence
Date Sat, 21 Oct 2017 04:49:00 GMT

     [ https://issues.apache.org/jira/browse/LUCENENET-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shad Storhaug resolved LUCENENET-592.
-------------------------------------
       Resolution: Fixed
         Assignee: Shad Storhaug
    Fix Version/s: Lucene.Net 4.8.0

These issues have now been addressed:

# Line 77/81: This private constructor overload was removed, as it is not necessary due to
the fact that UnescapedCharSequence implements ICharSequence
# Line 128: Changed condition from >= to <
# Overloads were added to accept StringBuilder (since in Java it implements ICharSequence
as well).

These issues were also escalated to the Lucene team at https://issues.apache.org/jira/browse/LUCENE-8001

> Lucene.Net.QueryParsers.Flexible.Core.Util.UnescapedCharSequence
> ----------------------------------------------------------------
>
>                 Key: LUCENENET-592
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-592
>             Project: Lucene.Net
>          Issue Type: Bug
>          Components: Lucene.Net.QueryParser
>    Affects Versions: Lucene.Net 4.8.0
>         Environment: .NET 4.5.1/4.6.2
>            Reporter: Greg Mulvihill
>            Assignee: Shad Storhaug
>             Fix For: Lucene.Net 4.8.0
>
>
> I noticed a few things that seem to be bugs in UnescapedCharSequence.cs.  
> https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.QueryParser/Flexible/Core/Util/UnescapedCharSequence.cs
> Line 77: I found no reference to the private constructor UnescapedCharSequence(UnescapedCharSequence
text), but needed to use it.
> Line 81: The for loop throws an exception as the condition statement goes beyond the
length of text due to '<=', rather than '<'.
> Line 128: The for loop immediately terminates as i will always fail the condition statement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message