lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator
Date Fri, 18 Aug 2017 08:36:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131905#comment-16131905
] 

ASF GitHub Bot commented on LUCENENET-565:
------------------------------------------

Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/209
  
    Jens,
    
    I have upgraded the project [here](https://github.com/NightOwl888/lucenenet/tree/replicator)
to work on .NET Standard 1.5, cleaned up the doc comments, and fixed the member accessibility.
    
    Currently, I am working on making a ReplicationHttpListener service that wraps TcpListener
and IReplicationService (containing only the Perform method). I have a working prototype (HTTP
1.0), but am still cleaning up the rough edges. It is very basic, but allows you to pass in
your own TcpListener so if someone were inclined to use HTTPS, authentication, client certificates,
etc. it is possible to do. It is pretty clear we still need integration with AspNetCore and
other thin clients since this will be incompatible with those, but this listener should handle
the general case where someone wants to build a thick client to act as a replication server,
and will work even on .NET Standard 1.5.
    
    My hope is to use the ReplicationHttpListener for the main tests. We should migrate the
AspNetCore specific tests to a new test project Lucene.Net.Tests.AspNetCore and build that
out with the fluent API similar to what I showed before (although, it may make sense to move
the reusable bits to the Support directory in Lucene.Net.Replicator). This will decouple the
projects so at least your suggestion of moving Lucene.Net.AspNetCore to a separate repository
is possible.
    
    Anyway, if you want to refactor ReplicationService into separate concerns that would be
okay as long as we keep the Perform method signature as it is.
    
    As for upgrading to AspNetCore 2.0, it would probably be better to multi-target (1.0 and
2.0), since we will be adding support to run .NET Core 2.0 to the project soon (running tests
on .NET Framework 4.5.1, .NET Core 1.0, and .NET Core 2.0).



> Port Lucene.Net.Replicator
> --------------------------
>
>                 Key: LUCENENET-565
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-565
>             Project: Lucene.Net
>          Issue Type: Task
>          Components: Lucene.Net.Replicator
>    Affects Versions: Lucene.Net 4.8.0
>            Reporter: Shad Storhaug
>            Priority: Minor
>              Labels: features
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message