lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Melgaard (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENENET-565) Port Lucene.Net.Replicator
Date Wed, 28 Jun 2017 12:40:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066426#comment-16066426
] 

Jens Melgaard commented on LUCENENET-565:
-----------------------------------------

{quote}
While that is how it was implemented in Java, it would probably make more sense to make the
"action constants" into action methods. If you look at the documentation (https://lucene.apache.org/core/4_8_0/replicator/org/apache/lucene/replicator/http/ReplicationService.html),
the URLs are like /<context>/<shard>/<action>. Therefore, in AspNetCore,
I would translate that into "/{context}/{shard}/{action}" with the 3rd URL segment mapping
to one of 3 different action methods (obtain, release, update) to have better separation of
concerns.
{quote}

Down the road I would agree that the current way they have implemented it requires rethinking
for .NET, that could be in that direction or another.

However for now I wan't to stick as close to the original source as I think is possible until
all tests are ported and running. When done refactoring can come into play.

{quote}
Suffice to say that for the time being all .NET Core/.NET Standard work on Lucene.Net must
be done using VS 2015. But fortunately VS 2015 and VS 2017 will run side-by-side on the same
machine.
{quote}

Yes they can, I ran out of space recently though so any old VS's had to go with allot of other
stuff >.<... Should get a new disk in the near future though, so I should be able to
install VS2015 again, until then I will have to limit my work the the other computers. 

> Port Lucene.Net.Replicator
> --------------------------
>
>                 Key: LUCENENET-565
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-565
>             Project: Lucene.Net
>          Issue Type: Task
>          Components: Lucene.Net.Replicator
>    Affects Versions: Lucene.Net 4.8.0
>            Reporter: Shad Storhaug
>            Priority: Minor
>              Labels: features
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message