lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Van Den Berghe, Vincent" <Vincent.VanDenBer...@bvdinfo.com>
Subject RE: [apache/lucenenet] LUCENE-5644: switch to simpler LIFO thread to ThreadState allocator d… (#208)
Date Tue, 13 Jun 2017 07:43:23 GMT
>> align with the project's whitespace specs
I’ve been trying to find the project’s code formatting document, but was unsuccessful.

>> Second, assuming we have no threading issues at the moment, how can we be sure this
doesn't introduce any?
We can be sure of nothing, since certainty is only as strong as the assumptions it is based
on.
However:

-          the tests have been appropriately changed and use the new code, and they all pass.

-          On a more personal level (even though it means nothing since you have to take my
unverifiable word for it), this code has been in production use these past 3 months on a 28-core
machine, all of them writing to a single IndexWriter for about a hundred million documents,
repeatedly. No problems were ever seen.
These things don’t show the absence of problems, but make me reasonably confident that the
code is sound.

Vincent

From: Itamar Syn-Hershko [mailto:notifications@github.com]
Sent: Tuesday, June 13, 2017 9:09 AM
To: apache/lucenenet <lucenenet@noreply.github.com>
Cc: Van Den Berghe, Vincent <Vincent.VanDenBerghe@bvdinfo.com>; Author <author@noreply.github.com>
Subject: Re: [apache/lucenenet] LUCENE-5644: switch to simpler LIFO thread to ThreadState
allocator d… (#208)


Thanks, that's an interesting one.

First, there's a lot of whitespace noise - can you remove it please? (align with the project's
whitespace specs)

Second, assuming we have no threading issues at the moment, how can we be sure this doesn't
introduce any? cc @NightOwl888<https://github.com/nightowl888>

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/lucenenet/pull/208#issuecomment-308027273>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/ARBXpku1AqOToF4KGaoBuQG8Pu83axMhks5sDjV4gaJpZM4N4A9a>.
Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message