lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pvginkel <...@git.apache.org>
Subject [GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.
Date Mon, 08 May 2017 13:24:06 GMT
Github user pvginkel commented on the issue:

    https://github.com/apache/lucenenet/pull/205
  
    I have, but this is a problematic one. This depends on a race condition, which is non-deterministic
by definition.
    
    The test case I created runs a few threads for a few seconds and fails when the exception
is thrown in one of the threads. Fun thing is that we're running until some timeout and then
cancelling the test. If we wouldn't the test could theoretically run indefinitely, never hitting
the race condition. However, since we run for some time interval, it could also be that the
problem is still there, but it just wasn't hit.
    
    I've ignored this test case because:
    
    * It's non deterministic, so the fact that it succeeds doesn't mean that the problem isn't
there, making the test case useless;
    * It prolongs running the test suite since we have to run for a non trivial amount of
time. I've set this to 5 seconds.
    
    This all being said: the test case is there so you can try it if you'd like. On my 8 core
workstation, it fails most of the time with the `HashSet<>` and succeeds all of the
time with the `ConcurrentHashSet<>`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message