lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From conniey <...@git.apache.org>
Subject [GitHub] lucenenet pull request #197: Fixing build errors
Date Tue, 06 Dec 2016 17:13:48 GMT
GitHub user conniey opened a pull request:

    https://github.com/apache/lucenenet/pull/197

    Fixing build errors

    Currently compiling master results in build errors:
    
    ```
      core\Search\JustCompileSearch.cs(204,46): error CS0507: 'JustCompileSearch.JustCompileFilteredDocIdSet.Match(int)':
cannot change access modifiers when overriding 'protected' inherited member 'FilteredDocIdSet.Match(int)'
[D:\git\conniey\lucenenet\src\Lucene.Net.Tests\Lucene.Net.Tests.csproj]`
    ```
    
    This is due to changes in [FilteredDocIdSet](https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Core/Search/FilteredDocIdSet.cs#L95)
from: 
    `protected internal abstract bool Match(int docid);` to `protected abstract bool Match(int
docid);`
    
    This fixes those errors.  An alternative would be to add the `internal` modifier back
to FilteredDocIdSet.
    
    @NightOwl888 Do you know why it was removed in the first place?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/conniey/lucenenet fixBuildIssues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit a7463ebe72b36bee8e5df5e98cff7f33af39e31a
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-12-06T17:06:12Z

    Fixing build errors by removing internal modifiers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message