lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core
Date Wed, 07 Dec 2016 14:28:45 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/191
  
    @conniey 
    
    FYI I have pushed QueryParser.Xml to master. This branch can now be brought up to date
by either merging master, or if you prefer you can update one chunk at a time by integrating
these working branches (in this order):
    
    https://github.com/NightOwl888/lucenenet/tree/spatial
    https://github.com/NightOwl888/lucenenet/tree/queryparser-flexible
    https://github.com/NightOwl888/lucenenet/tree/queryparser-xml
    
    Note that QueryParser.Xml has a dependency on some of the types in Sandbox. I ported only
as much of Sandbox as was needed to make QueryParser compile.
    
    I am now going to turn my focus on Highlighter, and since it has dependencies on ICU,
I will work from this branch. My hope is that by the time it is complete (I estimate about
2-3 days, but it could be longer if there are complications) that this branch will already
be merged to master or will be ready to merge.
    
    After we are working from a single branch, we can focus on fixing the issues with the
public API - we should probably wait to get up on MyGet until most of the breaking API changes
are completed.
    
    Versioning
    -----
    
    Note that I ran [a versioning experiment](https://www.myget.org/feed/nuget-port-version-test/package/nuget/NuGetVersionTest),
and it seems that our current versioning scheme is fully supported by NuGet 2.x. IMO, it is
better to use this versioning scheme than semver because this is a port. The version 4.8.0.123
both indicates it is a port of 4.8.0 and also allows us to do patches without incrementing
beyond 4.8.0 (which would put us out of sync with the Lucene version).
    
    I noticed you are using semver in the JSON files, which is why I brought it up. Can we
switch to the 4 segment version number instead of semver there, too? Or is that something
that our tooling won't support?
    
    Also see my [previous comment](https://github.com/apache/lucenenet/pull/191#issuecomment-263661505)
about supplying the version via CLI for local builds - is that something you can do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message