lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From conniey <...@git.apache.org>
Subject [GitHub] lucenenet pull request #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Date Sat, 12 Nov 2016 21:26:51 GMT
GitHub user conniey opened a pull request:

    https://github.com/apache/lucenenet/pull/194

    Updating from NUnit 2.6.3 to NUnit 3.5.0

    Updates the current test projects to NUnit 3.5.0.
    
    * Replaces obsolete `TestFixtureSetUp` and `TestFixtureTearDown` with `OneTimeSetUp` and
`OneTimeTearDown`
    * Replaces `[ExpectedException]` with `Assert.Throws<T>`
    * Adds a reason for [Ignore] tests because it is required now
    
    PR #191 depends on this because [dotnet-test-nunit ](https://github.com/nunit/dotnet-test-nunit)
uses NUnit 3.5.0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/conniey/lucenenet updateNUnit3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit ae1f6fd3305084eac90cbb98ed89ff698c933848
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-11-12T20:47:09Z

    Updating test projects to NUnit 3.5.0

commit 8889dd6d200c17d8dffb086bc36c3388ac474639
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-10-31T06:34:43Z

    Replacing obsolete [TestFixtureSetUp] with [OneTimeSetUp]

commit d2a26793d63894966d8c475abb6ccee7e092e7c7
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-10-31T05:34:49Z

    Replacing [ExpectedException(T)] with Assert.Throws<T>

commit 0171a22f2527a0904bfdc43aebcb58797dfbc81f
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-10-31T06:33:36Z

    Replacing obsolete [TestFixtureTearDown] with [OneTimeTearDown]

commit 9be007b70e810a2e96433560741fa90ab6a8c5fb
Author: Connie Yau <conniey@microsoft.com>
Date:   2016-11-12T21:05:16Z

    Adding Skip reason for [Ignore] tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message