lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From conniey <...@git.apache.org>
Subject [GitHub] lucenenet issue #191: Migrating Lucene.Net to .NET Core
Date Mon, 28 Nov 2016 19:05:48 GMT
Github user conniey commented on the issue:

    https://github.com/apache/lucenenet/pull/191
  
    @DevMk The issue is that the hyphenation folder is lower-case [Analysis/Common/hyphenation](https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Analysis.Common/Analysis/Compound/hyphenation).
 Fixing the casing in project.json would still result in an error because we resolve this
resource using the namespace of the class (which uses a capital H) (see [PatternParser.cs:
L366](https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.Analysis.Common/Analysis/Compound/hyphenation/PatternParser.cs#L366))
    
    Would you be able to create a PR against master and fix this?
    
    @NightOwl888 
    > That fixed the compile errors. But the test discovery has only found about 50% of
the tests. The Test output is full of errors like these...
    
    This is a bug in nunit/dotnet-test-nunit#76.  I updated the test projects to dotnet-test-nunit
beta3.  This should be resolved now.
    
    All the solutions, `Lucene.Net.sln` and `Lucene.Net.Portable.sln` open in Visual Studio
2015 now. I removed support for Visual Studio 2013 to make the experience consistent.  You
should be able to run the tests if you install the NUnit 3.0 VS extension in 2015.
    
    I migrated the projects and their associated test projects, Lucene.Net.Analysis.Stempel,
Lucene.Net.Tests.Grouping and Lucene.Net.Tests.Analysis.Stempel.  Last thing I need to do
is merge in your recent changes to master with Lucene.Net.Spatial. Is there anything else
I am missing?
    
    @Metamorphus 
    > So basically, it looks at the directory, where application assembly is located, and
grabs our web.config file, and treats it as its own configuration file. Is this correct behavior?
    
    Yes, that was how we had coded it. (I am open to better ways to look for a config file.)
A `NullReferenceException` should not be happening though.  Can you give me a small repro
so I can test/fix this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message