lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #195: Moving ICU dependent classes into a separate project
Date Wed, 23 Nov 2016 16:50:50 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/195
  
    No offense, but since @conniey has already provided a [working solution to the ICU bitness
issue](https://github.com/apache/lucenenet/pull/191#issuecomment-262379449), this seems like
a step backward instead of a step forward. At the very least, this will create a lot of merge
conflicts for #191 and an unneeded NuGet package to be created and then abandoned shortly
afterward. Not to mention, naming the package `Lucene.Net.Analysis.Common.ICU` is a poor naming
choice, since there is another package `Lucene.Net.Analysis.ICU`, which will cause lots of
confusion if/when it is ported. We are getting very close to the point where #191 can be merged
- we are probably just a few days away from that point, after which we will be able to get
the pre-release on NuGet shortly afterward.
    
    That said, it might pay off if some interested parties take a look at her [demo](https://github.com/conniey/lucenenet-demo)
and create prototypes to verify icu-dotnet works for all environments. That is what will happen
anyway when we get the pre-release on NuGet, but we might be able to head off any remaining
issues earlier with earlier feedback.
    
    In the meantime, if anyone needs an immediate solution to this, they should choose one
of the following options:
    
    1. [Manually build and pack #191](https://github.com/apache/lucenenet/pull/191#issue-186402248)
(recommended)
    2. Manually build this branch (will require some extra work to pack if you need NuGet
packages)
    3. Use the [MyGet packages](https://www.myget.org/gallery/lucene-net) and delete the ICU
DLLs (assuming you don't need Thai support or to utilize the SegmentingTokenizerBase). This
is not guaranteed to work, but has worked in at least one case.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message