lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet issue #191: [WIP] Migrating Lucene.Net to .NET Core
Date Thu, 10 Nov 2016 04:33:14 GMT
Github user synhershko commented on the issue:

    https://github.com/apache/lucenenet/pull/191
  
    > AFAIK, the Support namespace is for pieces that need to be sourced from the JDK and/or
close approximations to what is in the JDK that don't exist in the .NET framework.
    
    This is correct. Also can be used for adding code that makes emulation easier.
    
    > There are 2 different PriorityQueue types in Lucene.Net
    
    Is there a reason for this? Can we stay with one?
    
    > AFAIK, close() is being universally replaced with Dispose() rather than dealing with
the (confusing) redundancy.
    
    Correct. Will also allow for using `IDisposable` and `using() {}`. We should probably
start documenting those API deviations.
    
    > IMO, it makes more sense just to comment it out or remove the file from the project
    
    I concur. It may used by the randomized tests plugin, but we can't leave that out for
now.
    
    > We should probably just remove this type and use the native ObjectDisposedException.
    
    Sounds logically enough. Let's not forget to docuement all those changes, also in code
so future porting work doesn't rewind this work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message