lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request #190: Ported Analysis.Stempel
Date Tue, 04 Oct 2016 19:54:28 GMT
Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/190#discussion_r81839278
  
    --- Diff: src/Lucene.Net.Core/Support/DataInputStream.cs ---
    @@ -0,0 +1,323 @@
    +´╗┐using System;
    +using System.IO;
    +
    +namespace Lucene.Net.Support
    +{
    +    /// <summary>
    +    /// Java's DataInputStream is similar to .NET's BinaryReader. However, it reads
    +    /// using a modified UTF-8 format that cannot be read using BinaryReader.
    +    /// This is a port of DataInputStream that is fully compatible with Java's DataOutputStream.
    +    /// </summary>
    +    public class DataInputStream : IDataInput, IDisposable
    --- End diff --
    
    is it possible to add good tests around those, before they start being used from core
parts as well ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message