lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet pull request #187: Fixed 76 QueryParser Failing Tests
Date Sun, 02 Oct 2016 18:19:28 GMT
Github user NightOwl888 commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/187#discussion_r81474715
  
    --- Diff: src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs ---
    @@ -883,7 +883,7 @@ private void Jj_rescan_token()
                             p = p.next;
                         } while (p != null);
                     }
    -                catch (LookaheadSuccess ls) { }
    +                catch (LookaheadSuccess /*ls*/) { }
                 }
                 jj_rescan = false;
             }
    --- End diff --
    
    Well, the alternative would be to use `#pragma` to disable the warning messages for the
unused exception variable. Would you prefer it that way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message