lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet issue #188: Fixed 64 Failing Facet Tests and Finished Facet Implem...
Date Sun, 02 Oct 2016 15:00:24 GMT
Github user synhershko commented on the issue:

    https://github.com/apache/lucenenet/pull/188
  
    > A plain old generic Dictionary works fine, but may use more RAM than the designers
intended.
    
    I am totally okay with that. We should aim to get something out the door asap, and then
optimize later.  This shouldn't keep us from going ahead, and I'd consider this a 80/20 case.
    
    I say let's first release, then see who uses this. Once we see a lot of usage, we may
reconsider the implementation. WDYT?
    
    > if you really want to thank me for doing this, please spend a weekend porting one
of the remaining sections that doesn't have an open pull request.
    
    Indeed @eladmarg :)
    
    On that note, @NightOwl888 I have no idea where you are located, but if I happen to be
in your neighborhood during my travels do let me know and I'll buy you beers.
    
    > in another subject, which of the sub-project not ported yet?
    
    Let's have this discussion in the dev@ mailing list please. The list Shad provided may
be correct, but our priorities are different - the spatial module needs work, and there are
still failing tests at core. We can also skip Analysis.Kuromoji and Analysis.SmartCNand completely
now - they aren't worth our efforts now. So, Let's have that discussion in the right place
so other people could chime in as well.
    
    And thank you @csharptest :) -- @eladmarg @NightOwl888 let's see if we can wrap this PR
soon and move on to finish up the rest of the core and more important stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message