lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...
Date Sun, 11 Sep 2016 21:35:20 GMT
Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/185#discussion_r78302998
  
    --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs ---
    @@ -84,6 +90,6 @@
     //   (*) Delay Signing is an advanced option - see the Microsoft .NET Framework
     //       documentation for more information on this.
     //
    -[assembly: AssemblyDelaySign(false)]
    -[assembly: AssemblyKeyFile("")]
    -[assembly: AssemblyKeyName("")]
    +//[assembly: AssemblyDelaySign(false)]
    +//[assembly: AssemblyKeyFile("")]
    +//[assembly: AssemblyKeyName("")]
    --- End diff --
    
    That's a whole discussion that we can have on it's own thread, but I'm against strong-naming
in general. See http://code972.com/blog/2014/04/68-ditching-strong-naming-for-lucene-net.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message