lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet pull request #185: Ported Core.Util.Fst tests + Core.Util.Packed.T...
Date Sun, 11 Sep 2016 21:23:47 GMT
Github user NightOwl888 commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/185#discussion_r78302841
  
    --- Diff: src/Lucene.Net.Core/AssemblyInfo.cs ---
    @@ -84,6 +90,6 @@
     //   (*) Delay Signing is an advanced option - see the Microsoft .NET Framework
     //       documentation for more information on this.
     //
    -[assembly: AssemblyDelaySign(false)]
    -[assembly: AssemblyKeyFile("")]
    -[assembly: AssemblyKeyName("")]
    +//[assembly: AssemblyDelaySign(false)]
    +//[assembly: AssemblyKeyFile("")]
    +//[assembly: AssemblyKeyName("")]
    --- End diff --
    
    I have :). I couldn't get the InternalsVisibleTo to work right without commenting these.
    
    However, it would be better to ultimately have strong named libraries (at least for .NET
4.5) since it is not possible to reference a library that is not strong named from one that
is.  If we didn't strong name, anyone who currently is strong naming their assembly won't
be able to use Lucene.Net without compiling it themselves with a strong name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message