lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From conniey <>
Subject [GitHub] lucenenet pull request #183: Fix test failures and making SPIClassIterator m...
Date Mon, 29 Aug 2016 02:52:50 GMT
GitHub user conniey opened a pull request:

    Fix test failures and making SPIClassIterator more performant

    ### SPIClassIterator
    * Filtering out Microsoft/System assemblies to improve loading
    * Only adding public classes to the iterator:
       * Fixed test failures where MockCodec (which had a codec name "Lucene46") was being
loaded instead of Lucene46Codec because it was being found first in the iterator
    * Consolidated assembly loading code
    ### Test Failure Fixes
    *  Adding a default ctor to the Codecs that were not being found because SPIClassIterator
was skipping over them

You can merge this pull request into a Git repository by running:

    $ git pull fixTestFailures

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
commit 461a59c03a0c23d088d382ea3b0ddaa640427ced
Author: Connie Yau <>
Date:   2016-08-28T23:06:10Z

    Fixing test failures by adding default ctor in Codec classes

commit 6f406aa7a9f7a5b05832214b89edd247122d4cf1
Author: Connie Yau <>
Date:   2016-08-28T23:27:32Z

    Making MockCodecs private so they are not loaded in SPIClassIterator

commit 0f9228eb7996d1989f30ed38d101389ccbb322c2
Author: Connie Yau <>
Date:   2016-08-29T02:47:46Z

    Only loading non-Microsoft Assemblies to search for public types


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message