lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...
Date Tue, 30 Aug 2016 10:24:05 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/183
  
    @conniey 
    
    Thanks.
    
    It occurred to me that the AnalysisSPILoader only uses classes with a constructor that
take a single parameter of type `IDictionary<string, string>`. So, as long as we're
optimizing, perhaps the SPIClassIterator could be limited to default constructors and constructors
with one parameter of `IDictionary<string, string>`. That should eliminate a lot of
types from being considered.
    
    I did a quick search and the NamedSPILoader and AnalysisSPILoader are the only 2 classes
that use the SPIClassIterator in lucene, so it should be safe to do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message