lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #183: Fix test failures and making SPIClassIterator more per...
Date Mon, 29 Aug 2016 08:14:28 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/183
  
    Thanks. Do note that Analysis.Common also depends on SPIClassIterator, and I had to fix
it so it would load classes that don't have a default constructor (which is what the Analysis.Util.AnalysisSPILoader
requires). I also modified the NamedSPIClassLoader to filter out the classes without a default
constructor.
    
    However, the changes still haven't been merged into master from the [analysis-work branch](https://github.com/apache/lucenenet/tree/analysis-work).
Could you please verify these changes work with Analysis.Common and also that they won't cause
a merge conflict when it is merged into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message