lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #181: Analysis work
Date Sat, 27 Aug 2016 07:35:06 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/181
  
    Collator is an abstract Java class and there isn't that much to it. The most complicated
part is working out how to use the culture in a .NET-centric way. I took a stab at it in [this
commit](https://github.com/NightOwl888/lucenenet/commit/e6a037b2bb971b1015b2fc96eca663267df08273),
which you can grab if you want a starting point.
    
    BTW - I took a look at your stuff and noticed you still have the Locale class in there.
I have basically been using the System.Globalization.CultureInfo class as a direct replacement
for Locale, although in .NET we normally set the locale on the current thread and then use
it from there, so it might make more sense to just pick it up from the current context rather
than affixing it to the class.
    
    AFAIK, ICU4NET is *only* for supporting Thai. And I just got that part working in #182
(although I had to wrap the BreakIterator and add some functionality because it doesn't break
on Thai/non-Thai combinations of characters like it does in Java). This seems like it will
work for now.
    
    Frankly, I live in Thailand and can read and write Thai, but I am not even sure I will
be able to take advantage of the Thai support in Lucene.Net. I read through some of those
posts as well and from what I gather, this is supposed to be the interim solution to get Lucene.Net
off the ground and at some later point we can port ICU. I don't really see any reason why
a .NET core release couldn't just exclude Thai and the other classes that touch BreakIterator.
    
    But I understand where you are coming from. It would be nice not to have any unmanaged
code references, if possible. And if that is a priority for you, then go for it.
    
    Do note I have added pretty much all of the other missing Analysis.Common pieces/tests
(other than collation and Analysis.Miscellaneous.PatternAnalyzer and its tests) in #182. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message