lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ChristopherHaws <...@git.apache.org>
Subject [GitHub] lucenenet issue #181: Analysis work
Date Mon, 22 Aug 2016 16:13:47 GMT
Github user ChristopherHaws commented on the issue:

    https://github.com/apache/lucenenet/pull/181
  
    That's a shame that I didn't notice that the work was already done. I would love to help
with the conversion in your fork if you have no objections.
    
    As for the EntryIterator bug, I didnt get it completely working, however the change that
I made to `if (lastPos == outerInstance.keys.Length) return false;` made the iterator actually
return the next value instead of it skipping them. I did this because at that point in the
execution, `pos` is pointing to the next value, whereas `lastPos` is the current value, so
we need to see if the current value (`lastPos`) is the last value in the array. This piece
of code isn't in the java version and looks like it was added because .NET requires a bool
return value here. I was going to keep looking into it today, however if you already have
it fixed, perhaps I can pick something up off of your branch that you aren't working on?
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message