lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NightOwl888 <...@git.apache.org>
Subject [GitHub] lucenenet issue #176: Ported QueryParser
Date Mon, 15 Aug 2016 22:49:25 GMT
Github user NightOwl888 commented on the issue:

    https://github.com/apache/lucenenet/pull/176
  
    > This might diverge from other places in our codebase. Why is it public API anyway?
I can't really see anyone using it, except from people trying to customize the SimpleQueryParser
- which is simplistic in it's nature. I'd say let's make it nullable and either accept it's
a public API with not much expected usage, or hide it as non-public API. WDYT?
    
    What I meant was, it needs to pass the value through to the public API of another class
(I don't recall which offhand). The other class (or classes?) doesn't accept a nullable as
part of its public API, so to make it compatible (and do what the Java version does) it would
also either need to be nullable, or there would need to be a "guess" at that point in the
event it is null. I suppose I could try to figure out what the other class does in the event
of a null and move that logic into this class, but that would mean moving business logic from
one class into another.
    
    Anyway, can't rule out the possibility that those new flags are part of the problem causing
those 9 failing tests. If you have the setup to run in Java to figure out where the execution
paths diverge it would be a big help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message