lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...
Date Sat, 06 Aug 2016 18:48:02 GMT
Github user synhershko commented on the issue:

    https://github.com/apache/lucenenet/pull/177
  
    Looks great! Added a few comments
    
    (1) might have found a bug - you didn't change local vars in some occasions so I had commented
in some of them, (2) please document all test API changes that diverge from the Java code
in the appropriate places, so we don't chase after them in the future or override them by
mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message