lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geobmx540 <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Adding a MergeScheduler that uses Tasks
Date Tue, 17 May 2016 05:01:44 GMT
Github user geobmx540 commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/171#discussion_r63464721
  
    --- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
    @@ -0,0 +1,667 @@
    +´╗┐using System;
    +using System.Collections.Generic;
    +using System.Text;
    +using System.Threading;
    --- End diff --
    
    No bearing on this merge in particular - but why are the `usings` split here? Also placement
of the License should usually be at the top (I know here you are just following other files
- trying to start a discussion about what's the best way to go)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message