lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Adding a MergeScheduler that uses Tasks
Date Sat, 07 May 2016 22:12:41 GMT
Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/171#discussion_r62423417
  
    --- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
    @@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer, LuceneVersion matchVersion)
                 useCompoundFile = IndexWriterConfig.DEFAULT_USE_COMPOUND_FILE_SYSTEM;
                 openMode = OpenMode_e.CREATE_OR_APPEND;
                 similarity = IndexSearcher.DefaultSimilarity;
    +#if FEATURE_TASKMERGESCHEDULER
    +            mergeScheduler = new TaskMergeScheduler();
    +#else
                 mergeScheduler = new ConcurrentMergeScheduler();
    +#endif
    --- End diff --
    
    -1 for using compilation flags, can we decide which to initialize based on ctor param
(with default value) or keep the Java default but allow to override it via the object initializer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message