lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Connie Yau <conn...@microsoft.com>
Subject RE: Moving Lucene.NET to .NET Core
Date Wed, 13 Apr 2016 18:57:34 GMT
Hi Wyatt,

What is your github alias so I can add you as a collaborator on our fork? :)

Cheers,
Connie

-----Original Message-----
From: Wyatt Barnett [mailto:wyatt.barnett@gmail.com] 
Sent: Tuesday, April 12, 2016 5:46 PM
To: Elizabeth Maher (NEWMAN) <Elizabeth.Maher@microsoft.com>; dev@lucenenet.apache.org
Cc: Daniel Plaisted <daplaist@microsoft.com>; Bertrand Le Roy <beleroy@microsoft.com>
Subject: Re: Moving Lucene.NET to .NET Core

Thanks -- I might well need to take you up on that access. Working with the guys at https://na01.safelinks.protection.outlook.com/?url=Codebetter.com&data=01%7c01%7cconniey%40microsoft.com%7cbdf509364be34764276608d36334fdb1%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=b88YPR3Q%2fsEXM%2bHGjqb9CmEe1CwlAgZbZzwCbBCYErU%3d
to get some DNX issues sorted out, will report when I get somewhere on that problem.

Great to hear you are working on tests. That is probably the inflection point where CI really
begins to pay dividends.

On Tue, Apr 12, 2016 at 6:15 PM Elizabeth Maher (NEWMAN) < Elizabeth.Maher@microsoft.com>
wrote:

> Wyatt,
>
> The Portable solution now only includes projects that build on .NET Core.
> I'm working on the testing  framework right now and will let you know 
> when I have that working.
>
> If forking our repo works best for you, that's fine.  If getting 
> contribute access would be easier, Connie can give you that permission.
>
> Thanks,
> Elizabeth
>
> -----Original Message-----
> From: Wyatt Barnett [mailto:wyatt.barnett@gmail.com]
> Sent: Friday, April 8, 2016 3:03 PM
> To: dev@lucenenet.apache.org; Itamar Syn-Hershko <itamar@code972.com>
> Cc: Daniel Plaisted <daplaist@microsoft.com>; Bertrand Le Roy < 
> beleroy@microsoft.com>
> Subject: Re: Moving 
> https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=01%
> 7c01%7cconniey%40microsoft.com%7cbdf509364be34764276608d36334fdb1%7c72
> f988bf86f141af91ab2d7cd011db47%7c1&sdata=QxwDC5bq0wX%2bQVsaICDwE1HcYG3
> SWSD%2bU7qGA6YZsnk%3d to .NET Core
>
> Hi Elizabeth -- what I'll probably do is fork your repo and tweak 
> stuff to get it building where I have commit access and then figure 
> out if the changes are a pull request or some instructions if that works for you.
>
> On Thu, Apr 7, 2016 at 3:57 PM Elizabeth Maher (NEWMAN) < 
> Elizabeth.Maher@microsoft.com> wrote:
>
> > Hi Wyatt.
> >
> > Yes, there are two solutions in the move2dnx branch.  The portable 
> > solution one is at the root directory
> >
> https://github.com/conniey/lucenenet/blob/move2dnx/Lucene.Net.Portable
> .sln
> .
> > Just a warning, we haven't got all the projects building.  We are 
> > locally unloading projects that don't build and then we reload them 
> > one by one as we get them working.  (It's easier to keep the history 
> > cleaner this way.) If it would be helpful, we can change the 
> > Portable solution to just include the projects that build and then 
> > you can test it out.  Would that work for you?
> >
> > Thanks,
> > Elizabeth
> >
> > -----Original Message-----
> > From: Wyatt Barnett [mailto:wyatt.barnett@gmail.com]
> > Sent: Thursday, April 7, 2016 12:42 PM
> > To: Itamar Syn-Hershko <itamar@code972.com>; 
> > dev@lucenenet.apache.org
> > Cc: Daniel Plaisted <daplaist@microsoft.com>; Bertrand Le Roy < 
> > beleroy@microsoft.com>
> > Subject: Re: Moving
> > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=0
> > 1%
> > 7c01%7cElizabeth.Maher%40microsoft.com%7ce3b65e614748477aa80c08d35ff
> > 98
> > aa4%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=L0RsiCgohPvjQOOKhdB
> > F8 ahNIn%2fSDBR%2b%2fQ8lOpJQBoU%3d to .NET Core
> >
> > Hi -- build guy checking in.
> >
> > Yes, I think 2 solutions would work. No moral issues on my part 
> > about using
> > vs2015 for builds. Is it setup that way in the 
> > https://github.com/conniey/lucenenet/tree/move2dnx repo? If so I can 
> > try a few things and see how this would work over the weekend and 
> > let you know how we can make this work.
> >
> > Thanks for all the work -- this is really exciting especially given 
> > everything that has been happening in .NET over the last few weeks.
> >
> > On Thu, Apr 7, 2016 at 3:28 PM Elizabeth Maher (NEWMAN) < 
> > Elizabeth.Maher@microsoft.com> wrote:
> >
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1
> > > cc
> > > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9h
> > > mZ
> > > g7 kxWlk%2fMaBgP%2fUP5d4gPfpk%3d Community,
> > >
> > > After spending more time with this code base we have a better idea 
> > > of the best way to approach migrating everything .NET core.
> > >
> > > There are two types of work.  The first is to removing/replacing 
> > > external dependencies that do not work on .NET Core.  The second 
> > > is only use classes on available on .NET Core  Here are the major 
> > > work
> > items we have identified.
> > >
> > > 1.       Remove use of SharpZipLib dependency – completed
> > >
> > > 2.       Update ICU4NET dependency for .NET Core – In Progress
> > >
> > > a.       PR almost ready for main branch
> > >
> > > 3.       Remove Appache.NMS dependency – Starting
> > >
> > > a.       PR will be created for main branch.
> > >
> > > b.       We believe this is the highest risk part of the migration
> > > process.  Connie has a separate thread going for this.  We, will 
> > > of course make sure passing tests continue to pass.  We were 
> > > hoping for a little help from the community on this one.  Would it 
> > > be possible for a couple people to volunteer to try out this PR 
> > > (when it is
> > > ready) on their own applications?
> > >
> > > 4.       Make portable libraries to build .NET Core binaries – In
> > Progress
> > >
> > > a.       This work is being down at
> > > https://github.com/conniey/lucenenet/tree/move2dnx.  It looks like 
> > > a large change, but it’s actually just added files to support the 
> > > new project system and just a few minor changes to make sure code 
> > > compiles
> > on .NET Core.
> > >
> > > o   We will create a Lucene.Net.Portable.sln for build specifically for
> > > .NET Core.  We feel having two solutions will be the easiest 
> > > transition for the community and the CI build system.
> > >
> > > o   This work will include porting tests.  We will verify that
> currently
> > > passing tests will continue to pass.
> > >
> > > We would also like to make sure this project is set up for success.
> > > It’s awesome to see you already have a CI build process going.  We 
> > > will continue to make sure the that build works and make sure the 
> > > main
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1
> > > cc
> > > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9h
> > > mZ
> > > g7 kxWlk%2fMaBgP%2fUP5d4gPfpk%3d project builds with VS2013.
> > > However, you will need VS2015 to compile the Lucene.NET.Portable 
> > > solution.
> > > Would it be possible to switch to using
> > > VS2015 or add another CI build for the portable solution?
> > >
> > > Hopefully that answers your questions.  Please let me know if you 
> > > have further questions.
> > >
> > > Thanks,
> > > Elizabeth and Connie
> > >
> > > From: itamar.synhershko@gmail.com
> > > [mailto:itamar.synhershko@gmail.com]
> > > On Behalf Of Itamar Syn-Hershko
> > > Sent: Friday, March 11, 2016 3:10 AM
> > > To: dev@lucenenet.apache.org
> > > Cc: Elizabeth Maher (NEWMAN) <Elizabeth.Maher@microsoft.com>; 
> > > Daniel Plaisted <daplaist@microsoft.com>; Bertrand Le Roy 
> > > <beleroy@microsoft.com>
> > > Subject: Re: Moving
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1
> > > cc
> > > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9h
> > > mZ
> > > g7 kxWlk%2fMaBgP%2fUP5d4gPfpk%3d to .NET Core
> > >
> > > Hi Connie,
> > >
> > > That's great news, thanks!
> > >
> > > Please base your work on the master branch here:
> > > https://github.com/apache/lucenenet. We will fix the wording on 
> > > the website, thanks for noticing.
> > >
> > > Building via Lucene.NET.sln should work - can you let us know if 
> > > it doesn't?
> > >
> > > With regards to release dates and priorities - we currently don't 
> > > have any ETA since development is currently going on very slowly.
> > > The plan was to finish fixing the last of the failing tests in
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1
> > > cc
> > >
> > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9hmZ
> > g7 kxWlk%2fMaBgP%2fUP5d4gPfpk%3d Core, complete porting the major 
> > subprojects (e.g. Analysis) with tests, and then approach compiling 
> > on .NET Core. Can you help us progress based on this roadmap, or are 
> > your resources limited to compiling on .NET Core?
> > >
> > > As for PRs - do you have an estimation of the amount / scope of 
> > > changes required? is the result going to be another project or the 
> > > same codebase compiling on .NET Core?
> > >
> > > Thanks again for joining us in this effort!
> > >
> > > --
> > >
> > > Itamar Syn-Hershko
> > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fco
> > > de
> > > 97
> > > 2.com&data=01%7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be
> > > 74
> > > d2
> > > f005a08d35f1cc5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=JK4
> > > BW it 0hUzskla1QF1hK7pHPWgxnjOsZNemT%2fKRuiw%3d<
> > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fco
> > > de
> > > 97
> > > 2.com%2f&data=01%7c01%7cElizabeth.Maher%40microsoft.com%7c6804399b
> > > 6f
> > > 20
> > > 4e5da25208d3499da9fb%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > > i9 Xh FfIuPyHjJap73M%2fmAazkbOnus4JjKRtKltTx4As%3d>
> > > | @synhershko<
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2ft
> > > wi
> > > tt
> > > er.com%2fsynhershko&data=01%7c01%7cElizabeth.Maher%40microsoft.com
> > > %7
> > > c6
> > > 804399b6f204e5da25208d3499da9fb%7c72f988bf86f141af91ab2d7cd011db47
> > > %7
> > > c1 &sdata=dco5pTxx02cLjH9mNI3ByFBogaSYsbV%2frotmOzZTT2k%3d
> > > >
> > > Freelance Developer & Consultant
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1
> > > cc
> > > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9h
> > > mZ
> > > g7 kxWlk%2fMaBgP%2fUP5d4gPfpk%3d committer and PMC member
> > >
> > > On Fri, Mar 11, 2016 at 12:45 AM, Connie Yau 
> > > <conniey@microsoft.com <mailto:conniey@microsoft.com>> wrote:
> > > Hi all,
> > >
> > > Our team is working to make
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data
> > > =0
> > > 1%
> > > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35
> > > f1 
> > > cc5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya
> > > 9h
> > > mZg7kxWlk%2fMaBgP%2fUP5d4gPfpk%3d
> > run on .NET Core and was wondering if anyone else was working on 
> > this or would it be alright if we started this effort?
> > >
> > > Also, I was hoping that someone could answer a few questions I 
> > > have about this project:
> > >
> > > 1.       What branch should we be basing our effort on?
> > >
> > > *         In Community<
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fluce
> > ne 
> > net.apache.org%2fcommunity.html&data=01%7c01%7cElizabeth.Maher%40mic
> > ro 
> > soft.com%7c2f89a9c97be74d2f005a08d35f1cc5a2%7c72f988bf86f141af91ab2d
> > 7c d011db47%7c1&sdata=1XOtqMChZH06wKW2eJJhvY9UKl0BPWOc2LjgW6vbBks%3d
> > <
> > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2flu
> > > ce
> > > ne
> > > net.apache.org%2fcommunity.html&data=01%7c01%7cElizabeth.Maher%40m
> > > ic
> > > ro
> > > soft.com%7c6804399b6f204e5da25208d3499da9fb%7c72f988bf86f141af91ab
> > > 2d
> > > 7c
> > > d011db47%7c1&sdata=zLXh3HOEdMmXKOnnsMpH5n3lgti9F%2flvg%2b0rd8FztsI
> > > %3
> > > d>
> > > >, the documentation says "Most work currently happens on the 
> > > >branch
> > > named branch_4x<
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fg
> > > it
> > > -w
> > > ip-us.apache.org%2frepos%2fasf%3fp%3dlucenenet.git%3ba%3dshortlog%
> > > 3b
> > > h%
> > > 3drefs%2fheads%2fbranch_4x&data=01%7c01%7cElizabeth.Maher%40microsoft.
> > > com%7c2f89a9c97be74d2f005a08d35f1cc5a2%7c72f988bf86f141af91ab2d7cd
> > > 01 1d 
> > > b47%7c1&sdata=e8RMimvvNkfq5LGZfY3Yt2euKc%2f5D6TF%2bT5igMVFBoM%3d
> > > <
> > >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
> > -w 
> > ip-us.apache.org%2frepos%2fasf%3fp%3dlucenenet.git%3ba%3dshortlog%3b
> > h% 
> > 3drefs%2fheads%2fbranch_4x&data=01%7c01%7cElizabeth.Maher%40microsoft.
> > com%7c6804399b6f204e5da25208d3499da9fb%7c72f988bf86f141af91ab2d7cd01
> > 1d b47%7c1&sdata=FQN5oT40VBc6DWU674apXS6Ue5jFr8%2b%2bpZRPo5tzfbg%3d
> > >>."
> > > but it looks like the latest commits are in `master`
> > >
> > > 2.       How do we build this project?
> > >
> > > *         I read Build System & Scripts<
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fc
> > > wi
> > > ki
> > > .apache.org%2fconfluence%2fpages%2fviewpage.action%3fpageId%3d2782
> > > 42
> > > 29
> > > &data=01%7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f
> > > 00
> > > 5a
> > > 08d35f1cc5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=T43bf4fl
> > > 6B
> > > 1T
> > > wVQkjBmBrHiTvbpnzAoQcxjQvze5bjg%3d<
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fc
> > > wi
> > > ki
> > > .apache.org%2fconfluence%2fpages%2fviewpage.action%3fpageId%3d2782
> > > 42
> > > 29
> > > &data=01%7c01%7cElizabeth.Maher%40microsoft.com%7c6804399b6f204e5d
> > > a2
> > > 52
> > > 08d3499da9fb%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=xBmwDkHt
> > > rr
> > > j2 1%2bVPkKPmTEVxPobXRuf6v0bDVEjhR1U%3d>>
> > > but there doesn't appear to be a build.cmd in the repository< 
> > > https://github.com/apache/lucenenet>
> > >
> > > 3.       What is the expected release date for
> > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=0
> > 1% 
> > 7c01%7cElizabeth.Maher%40microsoft.com%7c2f89a9c97be74d2f005a08d35f1
> > cc
> > 5a2%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=FSW8OI4pOQ0vPya9hmZ
> > g7
> > kxWlk%2fMaBgP%2fUP5d4gPfpk%3d
> > v4.8?
> > >
> > > 4.       Regarding pull requests, is the preference for incremental
> > > changes (ie. Updating a set of APIs from one to another) or to 
> > > have a large pull request (ie. Moving to run on .NET Core with all 
> > > the associated project/code changes)?
> > >
> > > Thanks!
> > > Connie Yau
> > >
> > >
> >
>
Mime
View raw message