lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Connie Yau <conn...@microsoft.com>
Subject RE: Changing Thread management to Tasks
Date Mon, 11 Apr 2016 06:12:02 GMT
Thanks Oren for pointing this out to me! 

Are there any logging interfaces or classes (in Lucene.Net) I could dependency inject into
the MergeScheduler I am writing to log messages rather than just swallowing the exceptions
if an exception gets thrown during the merge or execution of the thread action.

Cheers,
Connie

-----Original Message-----
From: Oren Eini (Ayende Rahien) [mailto:ayende@ayende.com] 
Sent: Thursday, April 7, 2016 1:51 PM
To: dev@lucenenet.apache.org
Cc: Daniel Plaisted <daplaist@microsoft.com>
Subject: Re: Changing Thread management to Tasks

See here:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2flucenenet.apache.org%2fdocs%2f3.0.3%2fdc%2fdd1%2f_concurrent_merge_scheduler_8cs_source.html&data=01%7c01%7cconniey%40microsoft.com%7c6f2cdd270b214019b79408d35f266df0%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=46yECAyFkWJmbvYBYSbvJBBRd%2bzpSxvyfe3fZ5YjP7Q%3d

We had to write this:

https://github.com/ayende/ravendb/blob/master/Raven.Database/Indexing/ErrorLoggingConcurrentMergeScheduler.cs


*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811



On Thu, Apr 7, 2016 at 10:30 PM, Connie Yau <conniey@microsoft.com> wrote:

> Hi Oren,
>
> Thanks for letting me know about this! When you say "default merge 
> scheduler", do you mean ConcurrentMergeScheduler? Would you be able to 
> tell me about a scenario where the default merge scheduler would leak 
> exceptions? Also, are there a set of unit tests that test this?
>
> Thanks,
> Connie
>
> -----Original Message-----
> From: Oren Eini (Ayende Rahien) [mailto:ayende@ayende.com]
> Sent: Monday, April 4, 2016 10:58 PM
> To: dev@lucenenet.apache.org
> Cc: Daniel Plaisted <daplaist@microsoft.com>
> Subject: Re: Changing Thread management to Tasks
>
> Please note, one of the things that we had to do with this is to make 
> sure that this doesn't leak exceptions.
> The default merge scheduler is known to leak exceptions to the thread, 
> killing the process. Need to be sure to handle this
>
> *Hibernating Rhinos Ltd  *
>
> Oren Eini* l CEO l *Mobile: + 972-52-548-6969
>
> Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811
>
>
>
> On Tue, Apr 5, 2016 at 1:15 AM, Connie Yau <conniey@microsoft.com> wrote:
>
> > Hi,
> >
> > I've been working on trying to move
> > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=0
> > 1%
> > 7c01%7cconniey%40microsoft.com%7c574774f60d874dcc43da08d35d174289%7c
> > 72 
> > f988bf86f141af91ab2d7cd011db47%7c1&sdata=lcp54tq4j93yifdy8sWFmDNS2Oi
> > YZ MGl5EDtRcJJ%2bzU%3d to .NET Core and one of the issues I am 
> > having is
> migrating ConcurrentMergeScheduler and Threads.  I want to replace the 
> ConcurrentMergeScheduler with the default TaskScheduler and Threads 
> with Tasks. However, I noticed that there is a lot of logic to alter 
> merges based on the priority of their threads, etc.
> >
> > *         What is the reason we manage priority threads?
> >
> > o   If the default TaskScheduler is not sufficient, there is a
> > QueuedTaskScheduler<
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcode.
> > msdn.microsoft.com%2fSamples-for-Parallel-b4b76364%2fsourcecode%3ffi
> > le 
> > Id%3d44488%26pathId%3d462437453&data=01%7c01%7cconniey%40microsoft.c
> > om
> > %7c574774f60d874dcc43da08d35d174289%7c72f988bf86f141af91ab2d7cd011db
> > 47 %7c1&sdata=%2bqPmfU%2fxQ0hSPSpBWKMJYTkBCkkkOMh1PQ1j7kjwlDA%3d>
> > that manages priority
> >
> > Thanks,
> > Connie
> >
>
Mime
View raw message