lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Removing Apache.NMS dependency.
Date Fri, 22 Apr 2016 09:18:16 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/168#issuecomment-213348397
  
    Looks great, thanks!
    
    I add a few comments around `TestIndexWriterWithThreads`, it's not a trivial test and
it's worth checking on our CI whether or not it fails before and after your changes. If it
fails, it probably fails sporadically.
    
    There is a high risk of introducing thread safety issues here, so I'd want us to cover
our bases.
    
    Let's compare the code in this test to the Java version and make sure we are preserving
the same behavior. Once we know we do, let's run the tests many times, and strengthen them
where possible, to make sure this is air tight.
    
    WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message