lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Removing Apache.NMS dependency.
Date Fri, 22 Apr 2016 09:15:28 GMT
Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/168#discussion_r60711453
  
    --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs ---
    @@ -726,15 +724,15 @@ public override void Run()
                                     {
                                         if (Random().NextBoolean())
                                         {
    -                                        WriterRef.Value.PrepareCommit();
    +                                        WriterRef.PrepareCommit();
                                         }
    -                                    WriterRef.Value.Commit();
    +                                    WriterRef.Commit();
                                     }
    -                                catch (AlreadyClosedException ace)
    +                                catch (AlreadyClosedException)
                                     {
                                         // ok
                                     }
    -                                catch (System.NullReferenceException npe)
    +                                catch (NullReferenceException)
    --- End diff --
    
    why not just add a null check? why is this ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message