lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Itamar Syn-Hershko <ita...@code972.com>
Subject Re: Moving Lucene.NET to .NET Core
Date Fri, 25 Mar 2016 08:26:31 GMT
Hi Connie,

If the move to CoreCLR only requires getting rid of some dependencies, and
minor (or major but contained) code changes - I say we stay on the same
branch and make it cross compile. If this requires more intrusive changes,
let's understand their scope and think what the best strategy is.

I just merged your change to remove CSharpZipLib. Thanks for that.

The result will pretty much depend on our strategy with branches. Because
we have limited amount of dev power, I'd prefer we don't branch out and
keep the work focused on the master branch. If we can get a single code
base that cross compiles, with possibly some features lacking form the
CoreCLR version due to incompabilities, that'd be ideal.

Thanks for your help!

--

Itamar Syn-Hershko
http://code972.com | @synhershko <https://twitter.com/synhershko>
Freelance Developer & Consultant
Lucene.NET committer and PMC member

On Wed, Mar 23, 2016 at 12:50 AM, Connie Yau <conniey@microsoft.com> wrote:

> Hi all,
>
> I was wondering if I could get some additional input from regarding the
> questions Itamar asked and our current methods of addressing them:
>
> 1) Do you have an estimation of the amount / scope of changes required?
> After running the .NET Portability Analyzer over the existing code base,
> there are a few logical groups, we could create PRs for. There are possibly
> more later but these are the first few that we thought of:
> a) Replace SharpZipLib (which fixes
> https://issues.apache.org/jira/browse/LUCENENET-555)
> b) Replace Apache.NMS (ie. CountDownLatch could be replaced with
> CountdownEvent, etc.)
> c) Replace Thread management with Tasks
>
> 2) Is the result going to be another project or the same codebase
> compiling on .NET Core?
> Currently, we have a separate solution with separate .csprojs that compile
> into a Portable Class Library (PCL) which builds for both .NET 4.6 and
> ASP.NET Core 1.  The PCLs reference the same code that exists in the
> existing desktop solution. My team's end goal is to replace the desktop
> solution/project files with the portable class libraries so we build a
> single solution.
>
> Thanks!
> Connie
>
> References:
> - .NET Portability Analyzer:
> https://github.com/Microsoft/dotnet-apiport/releases
>
> -----Original Message-----
> From: Oren Eini (Ayende Rahien) [mailto:ayende@ayende.com]
> Sent: Saturday, March 12, 2016 10:32 PM
> To: dev@lucenenet.apache.org
> Cc: Elizabeth Maher (NEWMAN) <Elizabeth.Maher@microsoft.com>; Daniel
> Plaisted <daplaist@microsoft.com>; Bertrand Le Roy <beleroy@microsoft.com>
> Subject: Re: Moving Lucene.NET to .NET Core
>
> This was actually something that we needed, if you looked at the commit
> dates, this is a few weeks old.
>
> *Hibernating Rhinos Ltd  *
>
> Oren Eini* l CEO l *Mobile: + 972-52-548-6969
>
> Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811
>
>
>
> On Fri, Mar 11, 2016 at 1:11 PM, Itamar Syn-Hershko <itamar@code972.com>
> wrote:
>
> > Oren, Arkadiusz,
> > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=01%
> > 7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%7c72
> >
> f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZOA0lP1Kl9%2bCqR91RnbXCA%3d
> 3.x doesn't have any resemblance to the
> https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZOA0lP1Kl9%2bCqR91RnbXCA%3d
> 4.8 code base. Same goes to most dependencies. It would have been nice if
> this was contributed back to the project back in the day, but now it
> doesn't help.
> >
> > --
> >
> > Itamar Syn-Hershko
> > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcode97
> > 2.com&data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d
> > 34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Ae%2fy3ljKfiJFa
> > 3MTE4TsGJGKUiidSzK%2bMHPRFnEt%2fWM%3d | @synhershko
> > <https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2ftwit
> > ter.com%2fsynhershko&data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d
> > 01814cd61b5008d34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> > eTeQ4B1eigxjoA%2fBiim6aWlZ3%2ftuqWoiRbu9%2bGl7fiY%3d>
> > Freelance Developer & Consultant
> > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=01%
> > 7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%7c72
> > f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZOA0lP1K
> > l9%2bCqR91RnbXCA%3d committer and PMC member
> >
> > On Fri, Mar 11, 2016 at 7:53 AM, Arkadiusz Palinski <arek@ravendb.net>
> > wrote:
> >
> > > Also all of the dependencies of
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=0
> > > 1%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%
> > > 7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZO
> > > A0lP1Kl9%2bCqR91RnbXCA%3d are ported in the following
> > > branches:
> > >
> > > - https://github.com/ppekrol/PowerCollections/tree/master-dnx
> > > - https://github.com/ppekrol/GeoAPI/tree/master-dnx
> > > - https://github.com/ppekrol/NetTopologySuite/tree/master-dnx
> > > - https://github.com/ppekrol/Spatial4n/tree/master-dnx
> > >
> > > In order to compile
> > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=0
> > > 1%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%
> > > 7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZO
> > > A0lP1Kl9%2bCqR91RnbXCA%3d  put all of the above in the same
> > directory.
> > > We had to change directory structure and project names, because
> > > CoreCLR
> > is
> > > taking project names (and dll names) from directory names.
> > >
> > > Some tests are intentionally skipped for CoreCLR, mostly because
> > > binary serialization is no longer supported there.
> > >
> > >
> > > On Fri, Mar 11, 2016 at 7:42 AM, Oren Eini (Ayende Rahien) <
> > > ayende@ayende.com> wrote:
> > >
> > > > We ported Lucene 3.0.3 (with some modifications that we needed) to
> > > CoreCLR,
> > > > you can find it here:
> > > > https://github.com/ppekrol/lucene.net/tree/3.0.3-dnx
> > > >
> > > > *Hibernating Rhinos Ltd  *
> > > >
> > > > Oren Eini* l CEO l *Mobile: + 972-52-548-6969
> > > >
> > > > Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811
> > > >
> > > >
> > > >
> > > > On Fri, Mar 11, 2016 at 1:45 AM, Connie Yau
> > > > <conniey@microsoft.com>
> > > wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Our team is working to make
> > > > > https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&da
> > > > > ta=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34
> > > > > b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9ji
> > > > > wQ7XCnbwseZOA0lP1Kl9%2bCqR91RnbXCA%3d run on .NET Core and was
> > > wondering
> > > > > if anyone else was working on this or would it be alright if we
> > started
> > > > > this effort?
> > > > >
> > > > > Also, I was hoping that someone could answer a few questions I
> > > > > have
> > > about
> > > > > this project:
> > > > >
> > > > > 1.       What branch should we be basing our effort on?
> > > > >
> > > > > *         In Community<
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2flucenenet.apache.org%2fcommunity.html&data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=I99gQT4UA%2bqq3eS%2f59HLQ%2b9JVPgYjKUXoEnnUCXxdAk%3d
> >,
> > > the
> > > > > documentation says "Most work currently happens on the branch
> > > > > named branch_4x<
> > > > >
> > > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-w
> > ip-us.apache.org%2frepos%2fasf%3fp%3dlucenenet.git%3ba%3dshortlog%3bh%
> > 3drefs%2fheads%2fbranch_4x&data=01%7c01%7cconniey%40microsoft.com%7c19
> > 4dbd2d01814cd61b5008d34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&
> > sdata=El2rB94mWSftHHYZSfHgAM4reHfJ3aWx7s1ygM9o%2fmw%3d
> > > > >."
> > > > > but it looks like the latest commits are in `master`
> > > > >
> > > > > 2.       How do we build this project?
> > > > >
> > > > > *         I read Build System & Scripts<
> > > > >
> > > >
> > >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcwiki
> > .apache.org%2fconfluence%2fpages%2fviewpage.action%3fpageId%3d27824229
> > &data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b09
> > 44ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=cA9QhgMNzOWPzlOnKDb7
> > aw%2f6NM4%2bKEx04k4oGrulLmk%3d>
> > > > > but there doesn't appear to be a build.cmd in the repository<
> > > > > https://github.com/apache/lucenenet>
> > > > >
> > > > > 3.       What is the expected release date for
> https://na01.safelinks.protection.outlook.com/?url=Lucene.NET&data=01%7c01%7cconniey%40microsoft.com%7c194dbd2d01814cd61b5008d34b0944ef%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4YldC3Ca9jiwQ7XCnbwseZOA0lP1Kl9%2bCqR91RnbXCA%3d
> v4.8?
> > > > >
> > > > > 4.       Regarding pull requests, is the preference for incremental
> > > > > changes (ie. Updating a set of APIs from one to another) or to
> > > > > have a
> > > > large
> > > > > pull request (ie. Moving to run on .NET Core with all the
> > > > > associated project/code changes)?
> > > > >
> > > > > Thanks!
> > > > > Connie Yau
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Arek Palinski
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message