lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Use DateTime.UtcNow.Ticks instead of Envir...
Date Tue, 02 Jun 2015 00:47:34 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/149

    Use DateTime.UtcNow.Ticks instead of Environment.TickCount

    Use DateTime.UtcNow.Ticks instead of Environment.TickCount, otherwise test can fail with
low Environment.TickCount value resulting in negative value passed to DateTools.TimeToString
method. UtcNow.Ticks match closer what Lucene is doing by calling System.currentTimeMillis();
    
    Lucene: https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/search/TestDateFilter.java#L46
    
    Failing test:
    http://teamcity.codebetter.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=192345#_focus=5607

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet testdatefilter_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #149
    
----
commit cbdf72eeed366956a6806f48a69dbc77b67adaa6
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-06-02T00:41:30Z

    Use DateTime.UtcNow.Ticks instead of Environment.TickCount

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message