lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: use nullable int to matche Lucene, proper ...
Date Sun, 17 May 2015 02:05:31 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/146

    use nullable int to matche Lucene, proper string format usage

    TestLiveFieldValues test is not failing but console contains several failures in that
test that are getting ignored.
    
    First match the test to use nullable integer like Lucene does:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/search/TestLiveFieldValues.java)

    
    And then correct string format usage:
    
    https://github.com/apache/lucenenet/compare/master...laimis:livefieldvalues_fixes?expand=1#diff-db6d92460fa820ed96ad430d1c338012R180
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet livefieldvalues_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #146
    
----
commit d00a4262bd7a10596cbb1fd6a62292a14f397019
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-17T02:02:53Z

    use nullable int to matche Lucene

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message